[Libreoffice-bugs] [Bug 99711] Sidebar Position and Size displays incorrect width and height when units in mm

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=99711

--- Comment #27 from Roland Illig <roland.illig at gmx.de> ---
When fixing this bug, it might be a good idea to add a unit test, to prevent it
from being broken ever again.

As I looked around in PosSizePropertyPanel.cxx, I noticed that the spacing in
the code seems to be completely random. I found:

* if(expr)
* if (expr)
* if( expr )
* if ( expr )

* call(arg1, arg2)
* call(arg1,arg2)
* call( arg1, arg2 )
* call( "Width")

I would expect that a project as large as LibreOffice has a style guide for
these things.

In the "nChar == '-'" around line 496, the left-hand side is a modifiable
expression. The other code in that file uses the "if (object == subject)" style
to avoid this, although this typo is nowadays detected by any good compiler.

The number 315000 looks like a typo to me since it has 1 more 0 than expected.
The value 31500 makes more sense when measured in 1/100ths of degrees. By the
way, nTmp is a terrible variable name. I suggest nAngle instead.

All in all, it looks like there is a lot to do in this single file.
I haven't looked at the other files, I guess they look similar.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20191202/35f344ec/attachment-0001.html>