[Libreoffice-bugs] [Bug 129236] Checking for updates is slow

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=129236

Thomas Bertels <tbertels+bugzilla at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Checking for an update is   |Checking for updates is
                   |slow                        |slow

--- Comment #2 from Thomas Bertels <tbertels+bugzilla at gmail.com> ---
This 10 seconds delay actually seems redundant since there's already a 25
seconds delay only triggered when the update check isn't started from the
dialog box:
https://github.com/LibreOffice/core/blob/889dc7bffa02236bf2ad56b382997771f0fcf3c6/extensions/source/update/check/updatecheckjob.cxx#L124

> if (!m_bShowDialog) {
>     TimeValue tv = { 25, 0 };
>     m_aCondition.wait( &tv );

See also
https://github.com/LibreOffice/core/blob/330df37c7e2af0564bcd2de1f171bed4befcc074/extensions/README

== Application online update checking ==

When we start LO, first InitUpdateCheckJobThread is created, via
UpdateCheckJob::execute() (from
extensions/source/update/check/updatecheckjob.cxx),
as a reaction to a "onFirstVisibleTask" event. It waits 25 seconds (so that it
does not interfere with the startup itself), and then calls
UpdateCheck::initialize() (from
extensions/source/update/check/updatecheck.cxx).

This creates one more thread, UpdateCheckThread, that regularly checks whether
we have reached the time when we should ask for the update.  If yes, asks for
that, and shows the download button in the menu (if the new update is
available).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20191206/5630d698/attachment.html>