[Libreoffice-bugs] [Bug 129210] CRASH: recovering database file

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=129210

Xisco Faulí <xiscofauli at libreoffice.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |bibisected, bisected,
                   |                            |regression

--- Comment #8 from Xisco Faulí <xiscofauli at libreoffice.org> ---
(In reply to Caolán McNamara from comment #7)
> I can reproduce the assert but I don't think its weld-related
> 
> dbaccess/source/core/dataaccess/databasedocument.cxx:686 has an explicit
> 
> aGuard.clear(); // (load has an own guarding scheme) 
> 
> and then goes and passes that in to impl_attachResource
> 
> which calls 
> 
> _rDocGuard.clear();
> 
> on it.
> 
> Since
> 
> commit d38f9934f08939032cca64a32de58fa3901a88d5
> Date:   Sun Apr 7 15:29:35 2019 +0100
> 
>     [API CHANGE] Asserts to never clear already cleared guard
> 
> this asserts.
> 
> Not sure what the right fix is, but
> https://gerrit.libreoffice.org/#/c/84778/ seems to work, maybe Mike has an
> idea if that fix makes sense

Finally I learnt how to bisect this kind of issues
<https://wiki.documentfoundation.org/QA/Bibisect#How_to_bisect_File_Recovery_bugs>
and indeed it points to
https://cgit.freedesktop.org/libreoffice/core/commit/?id=d38f9934f08939032cca64a32de58fa3901a88d5

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20191209/18145ac0/attachment.html>