[Libreoffice-bugs] [Bug 123507] New: macOS: Insufficient context sensitive help

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=123507

            Bug ID: 123507
           Summary: macOS: Insufficient context sensitive help
           Product: LibreOffice
           Version: 6.2.0.3 release
          Hardware: x86-64 (AMD64)
                OS: Mac OS X (All)
            Status: UNCONFIRMED
          Severity: normal
          Priority: medium
         Component: LibreOffice
          Assignee: libreoffice-bugs at lists.freedesktop.org
          Reporter: menno.cornelssen at mailbox.org

Description:
After correction of languages.js (see Comment # 10 on bug 121532 from Stephan
Bergmann):

WRITER —> Format —> Paragraph... —> Text Flow tab —> Help invokes the

Browser —>
file:///Applications/LibreOffice.app/Contents/Resources/help/index.html?Target=swriter/modules/swriter/ui/paradialog/help&Language=en-US&System=MAC&Version=6.2

I get the page "Welcome to the LibreOffice Writer Help" and have to follow
several links to reach the help for the Text Flow tab:

Browser —> Welcome to the LibreOffice Writer Help
          
(file:///Applications/LibreOffice.app/Contents/Resources/help/en-US/text/swriter/main0000.html?System=MAC&DbPAR=WRITER)
        —> Menus
          
(file:///Applications/LibreOffice.app/Contents/Resources/help/en-US/text/swriter/main0100.html?&DbPAR=WRITER&System=MAC)
        —> Format
          
(file:///Applications/LibreOffice.app/Contents/Resources/help/en-US/text/swriter/main0105.html?&DbPAR=WRITER&System=MAC)
        —> Paragraph
          
(file:///Applications/LibreOffice.app/Contents/Resources/help/en-US/text/shared/01/05030000.html?&DbPAR=WRITER&System=MAC)
        —> Text Flow
          
(file:///Applications/LibreOffice.app/Contents/Resources/help/en-US/text/swriter/01/05030200.html?&DbPAR=WRITER&System=MAC)

My analysis:

(1) The "Help" isn't context sensitive for ALL Paragraph... tabs
(2) For some other menus I get correct help (e.g. Table —> Insert Table...)
(3) file:///Applications/LibreOffice.app/Contents/Resources/help/hid2file.js
seems to be outdated

In file:///Applications/LibreOffice.app/Contents/Resources/help/index.html —>

        var bookmark = target.slice(target.indexOf('/') + 1, target.length);
        var file = hid2fileMap[bookmark];
        // check first if a root bookmark @@nowidget@@ can be used
        if (file === undefined) {
            var b2 = bookmark.substring(0, bookmark.lastIndexOf("/")) +
'/@@nowidget@@';
            file = hid2fileMap[b2];
        }

The problem: Bookmarks “modules/swriter/ui/paradialog/help“
             and       “modules/swriter/ui/paradialog/@@nowidget@@“

are undefined in hid2fileMap[] (defined in
file:///Applications/LibreOffice.app/Contents/Resources/help/hid2file.js)
and therefore var file is undefined and the default var newURL = lang + '/' +
defaultFile + '?System=' + system + '&DbPAR=' + module
(with var defaultFile = 'text/swriter/main0000.html' and var module = "WRITER")
will be invoked.

In hid2fileMap[] there are 18 tags referencing text/swriter/01/05030200.html,
but all are “cui/ui/textflowpage/...“ and not
“modules/swriter/ui/paradialog/...“.


By the way: WRITER —> Table —> Insert Table... —> Help invokes the

Browser —>
file:///Applications/LibreOffice.app/Contents/Resources/help/index.html?Target=swriter/modules/swriter/ui/inserttable/help&Language=en-US&System=MAC&Version=6.2

ending in the correct file

        —>
file:///Applications/LibreOffice.app/Contents/Resources/help/en-US/text/swriter/01/04150000.html?System=MAC&DbPAR=WRITER&HID=modules/swriter/ui/inserttable/help#bm_@@nowidget@@

I have checked some other helps: Some show help for the appropriate context, a
lot others end in the page "Welcome to the LibreOffice Writer Help".

Steps to Reproduce:
1.Start LO WRITER
2.Menu Format --> Paragraph... --> Text Flow tab --> Help

(The Actual Result is wrong for ALL tabs!)

Actual Results:
Page "Welcome to the LibreOffice Writer Help"

Expected Results:
Page "Text Flow"


Reproducible: Always


User Profile Reset: No



Additional Info:
LibreOffice Version: 6.2.0.3
Build ID: 98c6a8a1c6c7b144ce3cc729e34964b47ce25d62
CPU threads: 2; OS: Mac OS X 10.11.6; UI render: default; VCL: osx; 
Locale: de-DE (de.UTF-8); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20190217/09a30b18/attachment-0001.html>