[Libreoffice-bugs] [Bug 122224] FILEOPEN DOCX The formula field is incorrect in the table, when we change the number format

bugzilla-daemon at bugs.documentfoundation.org bugzilla-daemon at bugs.documentfoundation.org
Sun Jan 6 19:34:58 UTC 2019


https://bugs.documentfoundation.org/show_bug.cgi?id=122224

--- Comment #5 from Terrence Enger <lo_bugs at iseries-guru.com> ---
Created attachment 148074
  --> https://bugs.documentfoundation.org/attachment.cgi?id=148074&action=edit
bibisect in bibisect-linux-64-5.4, tail of terminal output

Working on debian-buster in bibisect-linux-64-5.4 repository, I looked
only at the displayed result when LibreOffice opened the attached
.docx.  The bad commit is : commit 009e5f66, source hash c568eb7d,
2017-03-30.  The commit message for the source commit is:

    commit c568eb7d3bb4584867f0a1f0a7965f73097f009b
    Author: Jean-Sebastien Bevilacqua <realitix at gmail.com>
    Date:   Thu Feb 16 10:54:33 2017 +0100

        tdf#105975 Add Formula field parsing (docx) in SWriter

        Introduction
        ------------

        In MSWord, you can create a formula field (starting with =).
        When you save your file as `docx`, this `FORMULA` field is registered
        in you file (a field starting with `=`). In its current state,
        LibreOffice can't parse the `FORMULA` field in `docx` file.

        Context of this fix
        -------------------

        This fix is entirely located in the `DomainMapper_Impl.cxx` file
        because it's where the parsing is done.

        How this fix works
        ------------------

        First, we add `FORMULA` support by adding it to the `aFields[]`
variable.
        Next, to handle the `FORMULA` constant, we add a condition (swith case)
in
        `DomainMapper_Impl::CloseFieldCommand()` to call `handleFieldFormula`.

        Note
        ----

        In function `lcl_ExtractToken`, if command starts with `=`, it's a
        `FORMULA` field.

        Change-Id: If7d25de5413aa3133b22523d8a3f34ab6961adfc
        Reviewed-on: https://gerrit.libreoffice.org/34334
        Reviewed-by: Michael Stahl <mstahl at redhat.com>
        Tested-by: Jenkins <ci at libreoffice.org>

I am removing keyword bibisectRequest and adding bisected, bibisected;
and I am adding the author and Michael Stahl to cc.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20190106/86055ff3/attachment.html>


More information about the Libreoffice-bugs mailing list