[Libreoffice-bugs] [Bug 122619] New: Remove AppMenu export via DBus

Wed Jan 9 23:49:24 UTC 2019

https://bugs.documentfoundation.org/show_bug.cgi?id=122619

            Bug ID: 122619
           Summary: Remove AppMenu export via DBus
           Product: LibreOffice
           Version: 6.3.0.0.alpha0+ Master
          Hardware: All
                OS: Linux (All)
            Status: UNCONFIRMED
          Severity: trivial
          Priority: medium
         Component: graphics stack
          Assignee: libreoffice-bugs at lists.freedesktop.org
          Reporter: bjoern.michaelsen at libreoffice.org

Description:
LibreOffice tries to export its menues via dbus. This is obsolete as unity and
its HUD is discontinued, and on modern Ubuntu (18.04 LTS), when starting
LibreOffice and running:

 dbus-monitor |grep canonical

shows (among other things):

string "Could not get owner of name 'com.canonical.AppMenu.Registrar': no such
name"

As such this can be removed from the source. A starting point is the define:

 ENABLE_GMENU_INTEGRATION

which can be removed (its not set anymore anyway, it seems). That code enabled
unity menu integration in gtk2.

In gtk3, menu export is enabled by default, but unlikely has any effect as even
on Ubuntu, com.canonical.AppMenu.Registrar is not claimed anymore.

As such the functions found with:

 git grep com.canonical.AppMenu.Registrar

can be removed. While doing this, it should be taken care to also remove all --
now dead -- dependent code.

Steps to Reproduce:
1. Start LibreOffice on latest Ubuntu 18.04

Actual Results:
DBus Menu export isnt used. 

Expected Results:
If DBus Menu export is not used even on Ubuntu, it should be removed from the
code.

Reproducible: Always

User Profile Reset: No

Additional Info:

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20190109/9d011c90/attachment.html>