[Libreoffice-bugs] [Bug 115747] Can't edit file on samba shares ( see comment 28 )

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=115747

--- Comment #34 from Mike Kaganski <mikekaganski at hotmail.com> ---
(In reply to Thorsten Behrens (CIB) from comment #32)
> (In reply to Justin L from comment #31)
> > I have no idea why so much code was removed from the exception clause, but
> > restore the part with "if ( bUseSystemLock || !IsOOoLockFileUsed() )" solves
> > both the read-only problem on loading, and the save failure.
> 
> Because that hides the fact that the lock file could not be created. If in a
> deployment people are ok to only use system file locking, the config option
> UseDocumentOOoLockFile should be set to false.

In my opinion, the original fix (and this comment) somehow change the proper
notion of a feature/function that helps to reach some goals (reliably detect
locking/identify locking person) to a requirement for function (=if we cannot
detect locking reliably, then fail to work). Is that what is intended? and what
exact problem was solved by that change, that justifies making this
enforcement? The original problem in tdf#106942 only mentioned a corner case of
"drive full", which could be detected separately and acted accordingly.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20190111/31028d59/attachment.html>