[Libreoffice-bugs] [Bug 123021] Cancel doesn't cancel in Tools > Options > Chart colours

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=123021

--- Comment #2 from Jim Raykowski <raykowj at gmail.com> ---
Whew! Didn't know if Katarina's comment in Additional Info was intended that
this should actually be fixed quickly. I think it should be. So I jumped right
in trying to find how I introduced this bug. Could have saved myself some
stress by looking at the version (earliest affected) 6.0.7.3. This was way
before the palette selection patch I made was merged. :-)

Putting this one on the try to fix without breaking other things list.

For anyone that would like to try to fix this, here is where I was looking: 

pChartOptions is always true here:

cui/source/options/optchart.cxx

void SvxDefaultColorOptPage::dispose()
{
    // save changes
    if (pChartOptions)
    {
        pChartOptions->SetDefaultColors( pColorConfig->GetColorList() );
        pChartOptions->Commit();

        pColorConfig.reset();
        pChartOptions.reset();
    }
    ...
}

Now off to try to fix something I did break :(

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20190129/294f99a0/attachment.html>