[Libreoffice-bugs] [Bug 49033] Change case -> Sentence case doesn't honor selection; case of entire sentence changes (STR comment 20)

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=49033

--- Comment #42 from Philip Rayment <PJRayment at Yahoo.com.au> ---
(In reply to Mike Kaganski from comment #34)
> (In reply to V Stuart Foote from comment #31)
> 
> Let's discuss the details :-)
> 
> 1. What should be done when a sentence start is selected, but not to the
> sentence end? (I'm pretty confident the sentence start here should be
> capitalized.)
I'd suggest that the sentence start should be capitalised, and the rest of the
selection (not sentence) made lower case.
> 2. What should be done if a sentence end is selected, but not from start?
> (This one IMO is not that straightforward: we can capitalize the first
> selected character, or we may skip the sentence; my take would be capitalize
> first selected character.)
I think the selection should be made lower case.  That wouldn't do anything
that selecting lower-case would do, but if that's not what the user wanted, he
would realise that the "error" is his in not selecting the start of the
sentence.  And changing the selection to lower case would give exactly the same
outcome as that portion of the sentence would have if the whole sentence had
been selected, so there is some consistency there.
I make those two comment, though, on the basis of a user selecting part of *A*
sentence.  If one selects several sentences, but only parts of the first and
last sentences, doing it this way would make it inconsistent with Capitalise
Every Word (which you do raise in Q. 5). 
> 3. What should be done if selection starts in the middle of a word (possibly
> not the first in a sentence)? We could capitalize first character of the
> word (again not good for Shift+F3); or first selected character; or skip the
> sentence. (I'd capitalize first selected character.)
You're still asking about sentence case?  If so, I'd treat this the same as in
my answer to question 2.
> 4. What should we do when there's no selection? We could capitalize first
> character of current word (if any; like UPPERCASE at al work); or current
> sentence. (My take is Capitalize current sentence.)
If there is no selection, like other cases, the entire sentence (in this case)
should be assumed to be selected.
> 5. What should be done with Capitalize Every Word function, that now also
> expands to whole words, even if only parts are selected? It's not in
> Shift+F3 IIUC, but it would become inconsistent. (I'd say change it
> consistently.)
It is in Shift+F3.  I'm undecided on this one.
> 6. Should we only do the change for Word, or for other modules
> (Calc/Impress/etc) too for consistency? (I'd say yes.)
I'd agree yes, although Calc is the only other one I use more than rarely, and
I'd rarely use these functions in Calc, so my opinion may not be worth much
here.

Your questions are good ones, and I've offered some thoughts, but I probably
haven't properly considered all circumstances, so there may be good arguments
against what I've said.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20190130/44f0e584/attachment.html>