[Libreoffice-bugs] [Bug 118370] place text when importing from PDF in one text box instead many text boxes with one string

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=118370

--- Comment #12 from Justin L <jluth at mail.com> ---
(In reply to Regina Henschel from comment #11)
> How do you determine "imported from PDF"? As far as I see, it will become a
> general command.
Yes, there is nothing automatic here. The user has to select an area and then
command "Consolidate Text". After that it is the user's responsibility to
verify proper paragraph content and set paragraph properties. Nothing requires
that it can only be used for PDF imports, that is just the design-scope.

> Text boxes might be on different layers. What is the resulting layer?
Good question. I have no idea about layers The layer inserted would likely be
the same layer as the first textbox encountered, since xpInsOL =
pObj->getParentSdrObjListFromSdrObject().

> What is size and position of resulting text box?
It is the size of all of the marked text objects.
  rReplacement->SetSnapRect(GetMarkedObjRect());

> Is the resulting text box a new text box? If yes, what happens with the
> previous shapes?
Yes, it is a new textbox. SdrRectObj* rReplacement = new SdrRectObj(
getSdrModelFromSdrView(), OBJ_TEXT ).
The old textframes are deleted.
In terms of shapes, I would expect the text portion to just be removed from the
shapes, but the shapes themselves would not be deleted. (The initial
implementation ignores shapes and only deals with textframes, but I'm
interested in exploring the utility of supporting general SdrObjs that
HaveText.)

> The text boxes have styles, automatic or custom. Are they used? If you yes,
> how they are used? If not, what style is used?
No, the textboxes styles would not be used for the new textbox. It would just
be the default style that any new SdrRectObj gets. I expect that a PDF import
doesn't use textbox styles. The only way I could imagine applying a style would
be if all textboxes uses an identical style, and in that case it could
conceivably be applied to the new textbox as well. 

> Each of the text boxes can have a numbered list. Are the lists joined?
No.  Other than guessing at sentence-end, there is no content analysis done
during the consolidation.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20190712/501d1c55/attachment-0001.html>