[Libreoffice-bugs] [Bug 118370] place text when importing from PDF in one text box instead many text boxes with one string

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=118370

--- Comment #15 from Justin L <jluth at mail.com> ---
I updated my proposal to patch set 3.

(In reply to Regina Henschel from comment #14)
Thanks for giving your opinion that this should NOT be opened up to general
shapes, but should be strictly for textboxes. I've limited it to OBJ_TEXT
items.

> Grouped textboxes: enter group, consolidate, and everything vanishes.
Kinda fixed with another sledgehammer approach to just ungrouping everything. I
have no idea what is going on behind the scenes here. I suspect that either
objects are being freed, or SdrOutliner is being reset.

> If the layer is locked, the new text box is inserted in this layer anyway.
I changed the code so that the new text box is inserted into the current layer.
I wasn't able to discover the locked status of the layer though, since the only
lock function [IsLockedODF()] reports on something different.

> "Consolidate Text" works on Callouts and presentation objects too.
I can't reproduce. In my testing, callouts are !IsTextFrame(), so they
shouldn't have been included. However, since the code is now modified to only
include OBJ_TEXT, perhaps it works as you expect now.

> Numbered list in one text box followed by numbered list in the next text
> box is turned into a bullet list in my tests.
I can't reproduce.

> * Text boxes in "text along path"-mode are treated too.
I couldn't figure out how to create these.
It sounds like you may have developed a fairly comprehensive test document.
Perhaps you could attach it to this report. That would be helpful.

> If only one text box is marked together with another shape, then the
> text box is replaced by a new one, losing name, description and style.
Now that only OBJ_TEXT are supported, this was easily fixed.

> * If the user marks a shape in addition, the size and position for the new
> text box is taken from the entire marked area.
GetMarkedObjRect was returning a cached size, so it needed to be invalidated
and re-calculated.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20190715/f4404fb7/attachment.html>