[Libreoffice-bugs] [Bug 115251] LibreOffice draw hangs with 100% CPU after opening a pdf file

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=115251

Miklos Vajna <vmiklos at collabora.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |noelgrandin at gmail.com
         Resolution|---                         |FIXED

--- Comment #8 from Miklos Vajna <vmiklos at collabora.com> ---
This improved a lot in the 6.2 -> 6.3 timeframe. Oldest 6.3 is around 50s for
me, newest 6.3 is rather in the 20s range. Reverse bisecting points out:

commit bd44b3eef62f4325a189539d6ab1b90ca63cfc28
Author: Noel Grandin <noel.grandin at collabora.co.uk>
Date:   Wed Apr 24 13:40:59 2019 +0200

    tdf#89522 PERF FILEOPEN xlsx, part 1

    Inherit from tools::WeakBase non-virtually, so that we can use a
    static_cast in tools::WeakReference::get instead of a dynamic_cast.

    This takes the file-open time from 1m21 to 40s for me.

    Add a clang plugin to make sure we don't accidentally end up inheriting
    from tools::WeakBase more than once.

    Change-Id: I9c7c36403333f99094e1f9d8cce2ecd9200377f9
    Reviewed-on: https://gerrit.libreoffice.org/71231
    Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>
    Tested-by: Noel Grandin <noel.grandin at collabora.co.uk>

Thanks Noel. :-) I guess we can close this, then.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20190730/701e8e60/attachment-0001.html>