[Libreoffice-bugs] [Bug 125723] Check for updates is an empty dialog box (and all menu's are empty afterwards)

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=125723

--- Comment #9 from Telesto <telesto at surfxs.nl> ---
Created attachment 152173
  --> https://bugs.documentfoundation.org/attachment.cgi?id=152173&action=edit
Bibisect log

Sorry, second attempt. Bibisected the wrong thing the first time 

Bisected to
author  Jan-Marek Glogowski <glogow at fbihome.de> 2017-08-24 13:41:37 +0200
committer       Jan-Marek Glogowski <glogow at fbihome.de> 2017-09-22 13:00:13
+0200
commit  448e9da1b440561441602e3a0956218b2702767e (patch)
tree    4282d5093419247ffd8d2dc55af0ede3623ba6b2
parent  43fd2b2597ce7ac3307794c712e4d8e29e26db5c (diff)
tdf#111994 WIN workaround PostMessage delays
Fixes the "Multiple timers in queue" assertion by effectively
removing it.

When debugging it became obvious, that PostMessage returns, even
if the message was not yet added to the message queue.

The assert happens, because we start the timer in the Scheduler
before Invoke(), so it fires, if we block in Invoke(), and then
reset the timer after Invoke, if there were changes to the Task
list.

In this case it fires during Invoke(), the message is added. We
restart the timer, first by stopping it (we wait in
DeleteTimerQueueTimer, to be sure the timer function has either
finished or was not run). And the try to remove the message with
PeekMessageW, which doesn't remove the posted message.

Then the timer is restarted, and when the event is processed, we
end up with an additional timer event, which was asserted.

As a fix this adds a (microsecond) timestamp to the timer message,
which is validated in the WinProc function. So if we stop the
timer too fast, the event is ignored based on the timestamp.

And while at it, the patch moves timer related variables from
SalData into WinSalTimer.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20190613/eeec8756/attachment.html>