[Libreoffice-bugs] [Bug 125892] Time to export a certain PDF increased with in 10 fold (previously 30 seconds (6.0) now 5 minutes (6.4)

bugzilla-daemon at bugs.documentfoundation.org bugzilla-daemon at bugs.documentfoundation.org
Sun Jun 16 10:51:12 UTC 2019


https://bugs.documentfoundation.org/show_bug.cgi?id=125892

--- Comment #6 from Matteo Casalin <matteo.casalin at libreoffice.org> ---
The fix in
https://cgit.freedesktop.org/libreoffice/core/commit/?id=85613aa81a885488f99ed038f2254ddb0c8a1037
aimed to avoid considering an empty token (if rTree ended with a '/') when
validating the tree.
Comparing against the length of the string was an option that I assumed not to
introduce heavy load (since likely more expensive functions are called in
ImpIsTreeAvailable), but this seems to be not true.
I'm not familiar with the internals of this code, other options to achieve the
same result could be:

1. Performs checks as before, and then if bAvailable is false (would it be
false?) and rTree ends with '/' and we are parsing last token (which is empty)
then return true

2. Check if it's correct that a tree with final '/' is passed and fix the (PDF)
caller, if this is wrong. FilterConfigItem::ImpInitTree also uses the same
tree, I don't know if fixing the caller would introduce an issue here or if the
final '/' which is currently neglected in ImpIsTreeAvailable is problematic
also in FilterConfigItem::ImpInitTree.

I will try to have a look at this, but I have almost no spare time at the
moment so it can take a while.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20190616/36d7632f/attachment.html>


More information about the Libreoffice-bugs mailing list