[Libreoffice-bugs] [Bug 125978] New: Unreliable float comparisons in bridgetest

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=125978

            Bug ID: 125978
           Summary: Unreliable float comparisons in bridgetest
           Product: LibreOffice
           Version: 6.2.4.2 release
          Hardware: All
                OS: All
            Status: UNCONFIRMED
          Severity: enhancement
          Priority: medium
         Component: LibreOffice
          Assignee: libreoffice-bugs at lists.freedesktop.org
          Reporter: marcus.tomlinson at canonical.com

Description:
Hi, we've (Ubuntu) been seeing a fair bit of flakiness lately (particularly on
s390x) from: testtools/source/bridgetest/bridgetest.cxx

Looking into it, we found the culprit to be a series of 'float == float'
checks. Sure, most of the time these companions work, but now and then you'll
get a rounding error that breaks the test. Ideally the test should be comparing
floats by difference within the bounds of an epsilon, would you agree?

I've attached a patch for bridgetest.cxx that fixes the issue there, but this
would need to be fixed to the 2x cli tests, and in testiadaptor too.

Downstream bug report:
https://bugs.launchpad.net/ubuntu/+source/libreoffice/+bug/1832360

Steps to Reproduce:
1. Run bridgetest repeatedly

Actual Results:
Occasionally you'll get:
### float does not match! failed

Expected Results:
Test passes every time.


Reproducible: Sometimes


User Profile Reset: No



Additional Info:

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20190618/05f75788/attachment.html>