[Libreoffice-bugs] [Bug 123880] Opening xls file in previous versions of libre vs 6.2.0.3

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=123880

--- Comment #4 from Noel Grandin <noelgrandin at gmail.com> ---
You'll need to bisect from before commit
7ea01578eed8459678369d0256de016930b3af40 where I messed up XLS import.

We are correctly detecting this as XLS, and we call into the ORCUS XLS filter,
and then ORCUS complains with:

warn:sc:4715:4715:sc/source/filter/orcus/orcusfiltersimpl.cxx:75: Unable to
load file via orcus filter! 'BLACK' is not a valid RGB color string.

So I suspect your bisect will come to back to whereever we introduced the orcus
filter.

ORCUS appears to be complaining about the following stuff in the attached file:

   ss:Color="BLACK"

According to some microsoft docs:

"Specifies the color of this border. This value can be either a 6-hexadecimal
digit number in "#rrggbb" format or it can be any of the Microsoft® Internet
Explorer named colors (including the named Microsoft Windows® colors). This
string can also be the special value of "Automatic." This string is case
insensitive"

So it looks like orcus is missing out in this department, the relevant code in
orcus lives at the repo at
    https://gitlab.com/orcus/orcus/
in the source file
   src/liborcus/spreadsheet_types.cpp
in function 
    to_color_rgb

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20190306/4c115c03/attachment-0001.html>