[Libreoffice-bugs] [Bug 121092] Libreoffice 6.1.3.2 does not allow saving Advanced Properties options with SQLITE 3 over ODBC

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=121092

--- Comment #40 from Mike Kaganski <mikekaganski at hotmail.com> ---
I have setup a testing data connection, and tested myself.

I need to note that bibisect from comment 30 is indeed incorrect (though looks
amazingly relevant wrt affected files ;-D).

And the suggestion from comment 25 seems to be not a workaround after all, but
a proper solution:

ODatabaseModelImpl::getDefaultDataSourceSettings [1] sets the default for the
setting to false; that default is most probably taken to consideration at
*some* level when deciding if a value is different from default (i.e., it might
be simply dropped from some property set if it's equal to this default). On the
other hand, the change mentioned in comment 25 provides the opposite value for
default on a different level; that might also be considered likewise in the
process of writing the setting - so having them both makes the scenario likely
that neither value gets it to the content.xml in ODB.

Since the defaults in [1] are there at least since 2006 [2], they must be
relevant for all ODBs out there - so it's correct to change newly introduced
defaults accordingly.

I have checked that making the proposed change to that default of
RespectDriverResultSetType in
connectivity/registry/odbc/org/openoffice/Office/DataAccess/Drivers.xcu indeed
produces the "true" value into the ODB; while when "false", the value is not
present there.

I'm not sure if that is relevant to other connection types.

[1]
https://opengrok.libreoffice.org/xref/core/dbaccess/source/core/dataaccess/ModelImpl.cxx?r=435b64ec#1003
[2] https://git.libreoffice.org/core/+/0eb026293c88d422d701d1a06735d9cce5457ca9

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20190309/fd71ac85/attachment.html>