[Libreoffice-bugs] [Bug 120603] Misleading error messages resulting from fixes for bug #120353

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=120603

--- Comment #6 from Julien Nabet <serval2412 at yahoo.fr> ---
(In reply to Lionel Elie Mamane from comment #5)
>...
> Giving a different error message when the "input required" bit comes from
> the form or from the database can still be considered a worthy enhancement.

If I understand well, you want to distinguish these 2 cases:
- xFirstControlWithInputRequired
- xFirstGridWithInputRequiredColumn
see
https://opengrok.libreoffice.org/xref/core/svx/source/form/formcontroller.cxx?r=cec7ae9f#219

So in function FormController::approveRowChange
(cf
https://opengrok.libreoffice.org/xref/core/svx/source/form/formcontroller.cxx?r=cec7ae9f#3706)
instead of:
3706              OUString sMessage( SvxResId( RID_ERR_FIELDREQUIRED ) );
3707              sMessage = sMessage.replaceFirst( "#", rColInfo.sName );
It would be something like:
OUString sMessage( xFirstControlWithInputRequired?SvxResId(
RID_ERR_FIELDREQUIRED _DB):SvxResId( RID_ERR_FIELDREQUIRED_FORM ));

(or reuse RID_ERR_FIELDREQUIRED for DB and change the content to explicitly
quote database and add RID_ERR_FIELDREQUIRED_FORM)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20190321/f3b719c3/attachment.html>