[Libreoffice-bugs] [Bug 124022] Unhardcode different driver default settings

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=124022

--- Comment #5 from Lionel Elie Mamane <lionel at mamane.lu> ---
(In reply to Mike Kaganski from comment #0)

> so effectively this mandates that all drivers have
> same defaults which are equal to those in
> ODatabaseModelImpl::getDefaultDataSourceSettings, breaking the per-driver
> mechanism.

IMO, having per-driver defaults is important. SDBC drivers that know which
database they connect to (e.g. MySQL, PostgreSQL, as opposed to e.g. ODBC,
JDBC, ADO) should just set the right values by default silently, and not even
give the user UI to change them to known non-working values.

> Additionally, skipping writing of the settings to ODB which are equal to
> defaults creates another problem: an ODB only has settings which are not
> equal to the defaults *of the version which was used for its last saving* -
> and if opened in another version with changed defaults, the missing settings
> take new default values, which may break the connection.

In the context of DBMS-specific drivers, on the other hand, when the default is
wrong, it allows changing the default, and fixing the connection in newer
LibreOffice versions. Else, we fix it only for files created in the new
LibreOffice version.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20190326/470f8bd0/attachment.html>