[Libreoffice-bugs] [Bug 124247] Hex representation of color is used for recent color tool tip after split color button is clicked

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=124247

--- Comment #4 from Xisco Faulí <xiscofauli at libreoffice.org> ---
--- Comment #4 from Jim Raykowski <raykowj at gmail.com> ---
Here are some code pointers.

Classes to examine:

ToolboxButtonColorUpdater class
include/svx/tbxcolorupdate.hxx
svx/source/tbxctrls/tbxcolorupdate.cxx

SvxColorToolBoxControl class
include/svx/tbcontrl.hxx
svx/source/tbxctrls/tbcontrl.cxx

PaletteManager class
include/svx/PaletteManager.hxx
svx/source/tbxctrls/PaletteManager.cxx

Suggested approach:

Add a member function to the ToolboxButtonColorUpdater class that gets the
current color name.

Getting the current color name can be accomplished by:

parsing the color name from the tool box quick help text/tool tip text 
include/svx/tbxcolorupdate.hxx
sal_uInt16 const mnBtnId;
VclPtr<ToolBox> mpTbx;
include/vcl/toolbox.hxx
OUString ToolBox::GetQuickHelpText( sal_uInt16 nItemId )

or

adding a member variable to the ToolboxButtonColorUpdater class to store the
color name that is set in  
svx/source/tbxctrls/tbxcolorupdate.cxx
ToolboxButtonColorUpdater::Update(const NamedColor &rNamedColor) 

Replace the color hex representation string code with code that uses the
created get current color name function
svx/source/tbxctrls/tbcontrl.cxx
void SvxColorToolBoxControl::execute(sal_Int16 /*nSelectModifier*/)
include/svx/PaletteManager.hxx
PaletteManger::AddRecentColor

HTH

Message lost during the BZ outage ->
https://lists.freedesktop.org/archives/libreoffice-bugs/2019-March/176596.html

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20190327/75f4da3e/attachment.html>