[Libreoffice-bugs] [Bug 125151] New: Easy to delete form fields in protected sections

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=125151

            Bug ID: 125151
           Summary: Easy to delete form fields in protected sections
           Product: LibreOffice
           Version: 6.2.0.2 rc
          Hardware: All
                OS: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: medium
         Component: Writer
          Assignee: libreoffice-bugs at lists.freedesktop.org
          Reporter: jluth at mail.com

Created attachment 151212
  --> https://bugs.documentfoundation.org/attachment.cgi?id=151212&action=edit
deleting_fieldmarks.doc: the three types of fieldmarks are easily deleted in
protected sections

If the cursor is at the start of the formfield, then a delete will erase the
entire field.

This problem started in LO 6.2 with
https://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-4-4&id=63ec2e8d07dff652a68c9dc96859c4c61f26b9df
for bug 122201.

author  Serge Krot 2018-12-20 19:24:56 +0100
tdf#122201 sw: DOCX: allow editing of unprotected areas in protected doc

It looks like a delete request must pass several read-only checks, with Serge's
change of meaning of the protect_form flag, all the tests pass. If a section is
already protected, then the code follows a different path when evaluating
whether fieldmarks are editable, so a different outcome occurs if the section
is marked as protected.

Steps to reproduce:
1.) open the attached document and notice that each section is protected
2.) place the cursor in front of the checkbox and combobox and press delete.
The entire field is deleted.  Also true with the textbox, although you really
need to make sure you are at the beginning of the textbox definition.

Confirmation
A.) reload the test document
B.) edit the section and remove the protection.
C.) again attempt to delete the items
A "protected form" dialog tells you that editing here is not allowed. The
checkbox and combobox cannot be deleted (because
Options/Writer/Compatibility/Protect Forms is still enabled). The textbox can
still be deleted however.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20190507/6c0aac32/attachment-0001.html>