[Libreoffice-bugs] [Bug 125146] Menu Function “Reply Comment” does not work correctly

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=125146

Maxim Monastirsky <momonasmon at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |momonasmon at gmail.com

--- Comment #2 from Maxim Monastirsky <momonasmon at gmail.com> ---
(In reply to Harald Koester from comment #0)
> [2] Insert a comment and keep the cursor inside the comment.
> [3] Try to reply the comment: Menu: Edit > Comment > Reply Comment. This
> item is greyed. Expected: Item should not be greyed. Replying should be
> possible.
I think this part isn't a bug. Looking at the code, the Reply Comment command
is disabled when the current user is the author of the comment (because what's
the use in replying to your own comments?). Indeed, changing the user name in
Tools > Options... > LibreOffice > User Data, makes the command work in those
comments that were created with the old name. So this works as designed.

(In reply to Roman Kuznetsov from comment #1)
> ps: Reply function works fine from drop-down menu on comment
It appears to be a bug, and probably a regression from the conversion of this
menu to .ui format. Looking at the code
(AnnotationMenuButton::MouseButtonDown), it does the same check for the user
name, and when it's the same user it does:

pButtonPopup->EnableItem(FN_REPLY, false);

which isn't going to work, as the menu now doesn't have an item with id
FN_REPLY, and should instead be:

pButtonPopup->EnableItem(pButtonPopup->GetItemId("reply"), false);

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20190507/35c4d724/attachment-0001.html>