[Libreoffice-bugs] [Bug 125128] Option's AutoCaption preference should show Above as default position of table captions (again)

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=125128

Caolán McNamara <caolanm at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|libreoffice-bugs at lists.free |caolanm at redhat.com
                   |desktop.org                 |
             Status|NEW                         |ASSIGNED

--- Comment #9 from Caolán McNamara <caolanm at redhat.com> ---
The previous code doesn't look right either though. In 6.1

if (m_pPosBox->IsEnabled())
    m_pPosBox->SelectEntryPos(pOpt->GetPos());
else
    m_pPosBox->SelectEntryPos(0);

select position 0 if its disabled, leave it as the default if it is enabled.

Things start off disabled, so its 0 starting off and the option pos is ignored,
but on changing entries the settings are saved, so if you cursor away from the
first entry, then the entry 0 get saved as the default for the next visit.

So on initial visit

tables is disabled and shows "above", enable it and it shows "below". Cancel to
not save changes and revisit

tables is disabled, click on frame, click on table again, it shows "above",
enable it and it sticks as "above". Because the change away from frame and back
to table has saved the "above" position in

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20190523/21b69d82/attachment.html>