[Libreoffice-bugs] [Bug 125531] Empty CMIS properties dialog

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=125531

--- Comment #4 from Julien Nabet <serval2412 at yahoo.fr> ---
Code pointer:
https://opengrok.libreoffice.org/xref/core/sfx2/source/dialog/dinfdlg.cxx?r=da92911d#1145

I tried this:
diff --git a/sfx2/source/dialog/dinfdlg.cxx b/sfx2/source/dialog/dinfdlg.cxx
index ec3f57656ab9..87d1adbb1c38 100644
--- a/sfx2/source/dialog/dinfdlg.cxx
+++ b/sfx2/source/dialog/dinfdlg.cxx
@@ -1142,7 +1142,8 @@ SfxDocumentInfoDialog::SfxDocumentInfoDialog(
vcl::Window* pParent,
     m_nDocInfoId = AddTabPage("general", SfxDocumentPage::Create);
     AddTabPage("description", SfxDocumentDescPage::Create);
     AddTabPage("customprops", SfxCustomPropertiesPage::Create);
-    AddTabPage("cmisprops", SfxCmisPropertiesPage::Create);
+    if (rInfoItem.GetCmisProperties().hasElements())
+        AddTabPage("cmisprops", SfxCmisPropertiesPage::Create);
     AddTabPage("security", SfxSecurityPage::Create);
 }

+ remove assert here:
diff --git a/sfx2/source/dialog/tabdlg.cxx b/sfx2/source/dialog/tabdlg.cxx
index 79e2ad750ada..bc349c8d9c13 100644
--- a/sfx2/source/dialog/tabdlg.cxx
+++ b/sfx2/source/dialog/tabdlg.cxx
@@ -562,8 +562,6 @@ bool SfxTabDialog::StartExecuteAsync(
VclAbstractDialog::AsyncContext &rCtx )

 void SfxTabDialog::Start_Impl()
 {
-    assert(m_pImpl->aData.size() == m_pTabCtrl->GetPageCount()
-            && "not all pages registered");
     sal_uInt16 nActPage = m_pTabCtrl->GetPageId( 0 );

     // load old settings, when exists

It doesn't work. Cmis tab still appears but you can't select it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20190528/1d1c8f6e/attachment.html>