[Libreoffice-bugs] [Bug 121963] button flashing - mouse wheel zooming breaks

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=121963

--- Comment #50 from Armin Le Grand <Armin.Le.Grand at me.com> ---
Problem is that ViewObjectContactOfUnoControl_Impl::positionAndZoomControl is
used in two scenarios:
(1) During paint -> GridOffset is already part of ViewTransformation2D
(2) Other (IsVisible, getPrimSeq, ...) -> GridOffset *not* added
while (1) is coming from LazyControlCreationPrimitive2D::get2DDecomposition
while (2) comes from ViewObjectContactOfUnoControl::isPrimitiveVisible.

Using m_pAntiImpl->getObjectRange() in
ViewObjectContactOfUnoControl_Impl::positionAndZoomControl in both cases will
not work -> in case (1) the GridOffset will be taken into account *twice*. So
there are two alternatives:

(a) extend ViewObjectContactOfUnoControl_Impl::positionAndZoomControl with a
flag to internally know if GridOffset is alread added
(b) add GridOffset for all usages of (2) to ViewTransformation2D

Not sure what is better, have to think about it strategically/from the
underlying principle...

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20191101/72ea279c/attachment.html>