[Libreoffice-bugs] [Bug 128687] Internal leading not receiving same rounding as other font metrics

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=128687

--- Comment #4 from V Stuart Foote <vstuart.foote at utsa.edu> ---
(In reply to Caolán McNamara from comment #3)
> is it speculation or something you're able to check ? I'm not sure what we
> should do differently, we're deriving mnIntLeading from the rounded values.

Hmm, am I reading the code for mnIntLeading wrong?

derived at line 379         mnIntLeading = mnAscent + mnDescent - mnHeight;

the scaled mnAscent is converted and rounded, at line 374
the scaled mnDescent is converted and rounded, at line 375

but mnHeight remains as read from font metric, at line 83, with no scaling, nor
a conversion to float for rounding. Wouldn't that make a result for
mnIntLeading questionable.

Otherwise, will try to work up a sample text with: scaled, underlined, bolded,
and combining diacritics, with representative fonts, that should show any
effect of incorrect internal leading.

@Khaled, any input?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20191126/c41b8cde/attachment.html>