[Libreoffice-bugs] [Bug 124350] Inserting emoticon behaves not correctly

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=124350

--- Comment #9 from Tor Lillqvist <tml at iki.fi> ---
Ha. I found one very recent fix to exactly the
GenericSalLayout::SetNeedFallback() code I mentioned that had not been
cherry-picked to the cp-6.0 branch. With that, it works much better.

commit 16faad3657fad114aa984f92a14a5f212a2f8ff5
Author: Mark Hung <marklh9 at gmail.com>
Date:   Sun Jun 2 10:00:41 2019 +0800

    tdf#107487 fix font fallback for non-BMP characters.

    Non-BMP characters use two sal_Unicodes. It is necessary
    to advnace with OUString::iterateCodePoints safely instead of
    nCharPos + 1.

Will have to check what other emoji-related glitches there still are. But it is
probably best to file a separate bug for each specific glitch.

One that I noticed right away is that if you insert a flag emoji, when you
backspace over it to delete it, the code will delete each of the two characters
that combine to form the flag separately. For instance the flag emoji 🇨🇭
actually consists of two character, corresponding to the letters "C" and "H".
If I understand correctly, the flag glyphs are ligatures implemented in the
emoji font, that the two characters corresponding to country codes combine to
form, just like the fi ligature in traditional variable-width fonts is formed
by "f" and "i". If I backspace over the 🇨🇭, a later "C" in a square appears
instead.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20191008/68d1a560/attachment.html>