[Libreoffice-bugs] [Bug 128208] OOoSpotlightImporter.mdimporter causes segfault in mdworker macOS 10.15 Catalina with particular empty ODB file

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=128208

Julien Nabet <serval2412 at yahoo.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sbergman at redhat.com,
                   |                            |tml at iki.fi

--- Comment #8 from Julien Nabet <serval2412 at yahoo.fr> ---
Tor/Stephan: even if the zip file is corrupted, I think LO shouldn't crash.
I took a look to the crash log and the stack chain is:
GetMetadataForFile -> OOoSpotlightImporter
importDocument:contentType:attributes -> OOoSpotlightImporter openZipFileAtPath
-> readCentralDirectoryEntry -> readInt

then taking a look at "GetMetadataForFile", we got:
However, considering this code:
47     Boolean importOK = NO;
48     @try {
49         importOK = [importer importDocument:(NSString*)pathToFile
50                                 contentType:(NSString*)contentTypeUTI
51                                 
attributes:(NSMutableDictionary*)attributes];
52     }
53     @catch (NSException *exception) {
54         NSLog(@"main: Caught %@: %@", [exception name], [exception 
reason]);
55     }
see 
https://opengrok.libreoffice.org/xref/core/extensions/source/macosx/spotlight/GetMetadataForFile.m?r=c5a51893#34

Shouldn't the catch block catches any pb here?
How to prevent LO from crashing?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20191017/ba855b1c/attachment.html>