[Libreoffice-bugs] [Bug 50916] Allow more than 1024 columns in calc

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=50916

--- Comment #100 from Michael Meeks <michael.meeks at collabora.com> ---
Hi Kevin,

> Well.. I downloaded source code and prepared a folder, but.. I don't know how
> to start, see, etc... For me is big project at "first see". Any help I will
> appreciate it much :)

Great attitude ! so - I just pushed another small sample patch like this:

https://gerrit.libreoffice.org/81000 sc: rowcol: tdf#50916

And remembered the commit id - which should help link it into this bug as/when
it goes through gerrit.

In a nutshell, for each use of 'MAXCOL' we need to classify whether this is an
'easy' one - ie. we have a well defined use-case, and an in-range column (it
seems we use MAXCOL+1 as an out-of-bound magic/invalid) state. And for all the
easy ones we need to just replace the macro MAXCOL with pDoc->MaxCol() - for
some value of pDoc [ we need a reliable pointer and/or reference to the
document we are using that reference for ].

Hopefully that makes sense. I would submit these in small chunks (as above) to
gerrit - and let our CI system compile and test the result; you could possibly
even edit inside gerrit for this one - but best to get familiar with doing that
on the real code.

Please do CC me or Noel for reviews,

Thanks ! =)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20191017/e3b51f4f/attachment-0001.html>