[Libreoffice-bugs] [Bug 123848] "Compare Document": Changes misrepresented as new document sections

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=123848

László Németh <nemeth at numbertext.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |michael.stahl at cib.de

--- Comment #6 from László Németh <nemeth at numbertext.org> ---
Adding Cc: to Michael Stahl

Note: this is not a real regression, because the sections were never correct:
the problem was the their removing previously, see the attached screenshots.

My bibisected commit was reverted, but the problem still exists.

When I revert my other changes with the following patch, saving still changes
the style of the deletion (likely according to the new redline changes made by
Michael Stahl):

diff --git a/sw/source/core/doc/DocumentRedlineManager.cxx
b/sw/source/core/doc/DocumentRedlineManager.cxx
index 2372429afc70..ef8030ce6b5a 100644
--- a/sw/source/core/doc/DocumentRedlineManager.cxx
+++ b/sw/source/core/doc/DocumentRedlineManager.cxx
@@ -2012,7 +2012,7 @@ DocumentRedlineManager::AppendRedline(SwRangeRedline*
pNewRedl, bool const bCall
             {
                 if ( bCallDelete && RedlineType::Delete == pNewRedl->GetType()
)
                 {
-                    if ( pStt->nContent != 0 )
+                    if ( 0 && pStt->nContent != 0 )
                     {
                         // tdf#119571 update the style of the joined paragraph
                         // after a partially deleted paragraph to show its
correct style

In my opinion, the problem was bigger previously, because the actual text
formatting has changed: accepting the changes resulted losing of paragraph
formatting. For example, "chapter 3.3 Exceptions" became a normal paragraph.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20190906/78949238/attachment.html>