[Libreoffice-bugs] [Bug 116936] Firebird SDBC should implement XRowUpdate interface

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=116936

--- Comment #15 from Julien Nabet <serval2412 at yahoo.fr> ---
(In reply to Lionel Elie Mamane from comment #14)
> So, I'm sitting with btomi96 right now... The firebird driver says it
> supports only read-only in ODatabaseMetaData::supportsResultSetConcurrency
> in DatabaseMetaData.cxx
> 
> That's why... That needs to be enlarged. What we should declare as supported
> exactly is not 100% clear at this point. For testing purposes (not ready to
> commit), just change this (and ODatabaseMetaData::supportsResultSetType
> above) to always return true.
> 
> And you'll also need to support/test record deletion and insertion, see the
> IDL interface, should be not too hard to write the test code for that.

I made the changes so:
- ODatabaseMetaData::supportsResultSetConcurrency always returns true
- ODatabaseMetaData::supportsResultSetType always returns true

+ 
- ODatabaseMetaData::isReadOnly always returns false
- OResultSet::OResultSet contains:
 m_nResultSetConcurrency(css::sdbc::ResultSetConcurrency::UPDATABLE)
instead of 
 m_nResultSetConcurrency(css::sdbc::ResultSetConcurrency::READ_ONLY)

Still the same error ("The result set is read-only") :-(

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20190913/f5c2a140/attachment.html>