[Libreoffice-bugs] [Bug 90653] Opening .csv : Problem with rows

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=90653

Julien Nabet <serval2412 at yahoo.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |erack at redhat.com

--- Comment #18 from Julien Nabet <serval2412 at yahoo.fr> ---
Tristan:the simplest thing would be to stop when there's a pb

Eike: do you think we may add some throw exception or at least an assert in
https://opengrok.libreoffice.org/xref/core/sc/source/ui/docshell/impex.cxx?r=f805e0b9#636
in else part?

626  static bool lcl_appendLineData( OUString& rField, const sal_Unicode* p1,
const sal_Unicode* p2 )
627  {
628      OSL_ENSURE( rField.getLength() + (p2 - p1) <= SAL_MAX_UINT16,
"lcl_appendLineData: data overflow");
629      if (rField.getLength() + (p2 - p1) <= SAL_MAX_UINT16)
630      {
631          rField += OUString( p1, sal::static_int_cast<sal_Int32>( p2 - p1 )
);
632          return true;
633      }
634      else
635      {
636          rField += OUString( p1, SAL_MAX_UINT16 - rField.getLength() );
637          return false;
638      }
639  }

Indeed, putting more than SAL_MAX_UINT16 characters in a cell is more than
suspect no ?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20190918/b4c44c6d/attachment.html>