[Libreoffice-bugs] [Bug 127645] LibreOffice Crashes or Freezes, if an Update of an Extension is Available

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=127645

Julien Nabet <serval2412 at yahoo.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |caolanm at redhat.com

--- Comment #2 from Julien Nabet <serval2412 at yahoo.fr> ---
Caolán: noticing
https://cgit.freedesktop.org/libreoffice/core/commit/?id=4c3e0b2400c6b101a89f21e2268d5b696770fb9c,
thought you might be interested in this one.

I think OSL_ASSERT should be a real assert here.
This line seems a bit weird:
m_xUpdates->set_id(nEntry,
OUString::number(reinterpret_cast<sal_Int64>(pEntry)));

shouldn't we use pEntry->m_nIndex in a way?

Also, even if this line was before the quoted commit:
sal_uInt16 nIndex = sal::static_int_cast< sal_uInt16 >( m_enabledUpdates.size()
);
can't we do more simple with:
sal_uInt16 nIndex(m_enabledUpdates.size());
?

Here's the small bt from this part:
#0  0x00007fff272a4d71 in
dp_gui::UpdateDialog::insertItem(dp_gui::UpdateDialog::Index*, bool)
(this=0x7fffe51ba5c0, pEntry=0x55555ba05410, bEnabledCheckBox=true)
    at
/home/julien/lo/libreoffice/desktop/source/deployment/gui/dp_gui_updatedialog.cxx:549
#1  0x00007fff272a5043 in dp_gui::UpdateDialog::addEnabledUpdate(rtl::OUString
const&, dp_gui::UpdateData const&) (this=0x7fffe51ba5c0, name="LanguageTool
Version 4.6", data=...)
    at
/home/julien/lo/libreoffice/desktop/source/deployment/gui/dp_gui_updatedialog.cxx:577
#2  0x00007fff272a354e in
dp_gui::UpdateDialog::Thread::update(dp_gui::UpdateDialog::DisabledUpdate
const&, dp_gui::UpdateData const&) const (this=0x55555c581cb0, du=...,
data=...)
    at
/home/julien/lo/libreoffice/desktop/source/deployment/gui/dp_gui_updatedialog.cxx:437
#3  0x00007fff272a2804 in dp_gui::UpdateDialog::Thread::execute()
(this=0x55555c581cb0) at
/home/julien/lo/libreoffice/desktop/source/deployment/gui/dp_gui_updatedialog.cxx:324
#4  0x00007ffff64a058e in salhelper::Thread::run() (this=0x55555c581cb0) at
/home/julien/lo/libreoffice/salhelper/source/thread.cxx:40

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20190919/97d4ceb4/attachment-0001.html>