[Libreoffice-bugs] [Bug 109158] slower loading of a huge AutoCorrect replacement table

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=109158

V Stuart Foote <vstuart.foote at utsa.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |---

--- Comment #63 from V Stuart Foote <vstuart.foote at utsa.edu> ---
(In reply to Xisco Faulí from comment #53)
> (In reply to Xisco Faulí from comment #52)
> > @tommy27, @V Stuart Foote, Could you please check again this issue with a
> > master build containing noel's commits ?
> 
> Any update?
> Meanwhile, I'm going to backport both commits to libreoffice-6-3, you know,
> deliver early and often...

Hmm, compared loading (so no language change) of attachment 134684 (which I
renamed for my en-US locale).

Comparing master from 2019-09-14 to latest 2019-09-23 with all Noel's patches.

empty cache user/autocorr
Open Writer
Tools -> AutoCorrect -> AutoCorrect Options...

2019-09-14 :: 20s openings (10 repetitions)
0d0e8533afe565564835e6d51500e64066fd565b

2019-09-23 :: 21s openings (10 repetitions)
e1b51d4588b4b39592bb94dd5bb90de5e04d061e

So we are actually slower for this obscenely large autocorrect table... but
probably more correct ;-)

And with an installed 6.3.1.2 release build :: 16s openings (10 repetitions)
b79626edf0065ac373bd1df5c28bd630b4424273

So backport of Noel's optimizations is maybe not a good idea, yet?

And for comparison 5.3.7.2 release build :: 5s openings (10 repetitions)
6b8ed514a9f8b44d37a1b96673cbbdd077e24059

All testing on same Windows 10 Home 64-bit en-US (1903) laptop system with
Samsung SSD.

Reopening... but might be better to move to a new issue?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20190923/3be23951/attachment-0001.html>