[Libreoffice-bugs] [Bug 127748] crash on modify a frame style, which has previously got writing-mode bt-lr

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=127748

--- Comment #5 from Julien Nabet <serval2412 at yahoo.fr> ---
Pb is in
https://opengrok.libreoffice.org/xref/core/editeng/source/items/frmitems.cxx?r=c6c8de5a#3324:
3322  const char* getFrmDirResId(size_t nIndex)
3323  {
3324      const char* const RID_SVXITEMS_FRMDIR[] =
3325      {
3326          RID_SVXITEMS_FRMDIR_HORI_LEFT_TOP,
3327          RID_SVXITEMS_FRMDIR_HORI_RIGHT_TOP,
3328          RID_SVXITEMS_FRMDIR_VERT_TOP_RIGHT,
3329          RID_SVXITEMS_FRMDIR_VERT_TOP_LEFT,
3330          RID_SVXITEMS_FRMDIR_ENVIRONMENT
3331      };
3332      return RID_SVXITEMS_FRMDIR[nIndex];

When testing, I got nIndex = 5, so out of range.

A new constant must be declared in
https://opengrok.libreoffice.org/xref/core/include/editeng/editrids.hrc?r=5f5bfddf#269
269 #define RID_SVXITEMS_FRMDIR_HORI_LEFT_TOP      
NC_("RID_SVXITEMS_FRMDIR_HORI_LEFT_TOP", "Text direction left-to-right
(horizontal)")
270 #define RID_SVXITEMS_FRMDIR_HORI_RIGHT_TOP     
NC_("RID_SVXITEMS_FRMDIR_HORI_RIGHT_TOP", "Text direction right-to-left
(horizontal)")
271 #define RID_SVXITEMS_FRMDIR_VERT_TOP_RIGHT     
NC_("RID_SVXITEMS_FRMDIR_VERT_TOP_RIGHT", "Text direction right-to-left
(vertical)")
272 #define RID_SVXITEMS_FRMDIR_VERT_TOP_LEFT      
NC_("RID_SVXITEMS_FRMDIR_VERT_TOP_LEFT", "Text direction left-to-right
(vertical)")
273 #define RID_SVXITEMS_FRMDIR_ENVIRONMENT        
NC_("RID_SVXITEMS_FRMDIR_ENVIRONMENT", "Use superordinate object text direction
setting")

I thought about "RID_SVXITEMS_FRMDIR_VERT_BOT_LEFT" but what to put in
description?
"Text direction left-to-right (vertical, from bottom)"

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20190925/af6c5403/attachment.html>