[Libreoffice-bugs] [Bug 127748] crash on modify a frame style, which has previously got writing-mode bt-lr

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=127748

--- Comment #7 from Julien Nabet <serval2412 at yahoo.fr> ---
(In reply to Miklos Vajna from comment #6)
> I planned to get to this in the near future, but if you Julien are faster,
> it's great. :-)
> 
> Your UI string suggestion makes sense to me, it contains the btlr info and
> is consistent with the other existing strings.

Thank you Miklos for your feedback!

Here's a patch:
diff --git a/editeng/source/items/frmitems.cxx
b/editeng/source/items/frmitems.cxx
index 0d49c25681b6..4cb09608cf2e 100644
--- a/editeng/source/items/frmitems.cxx
+++ b/editeng/source/items/frmitems.cxx
@@ -3327,7 +3327,8 @@ const char* getFrmDirResId(size_t nIndex)
         RID_SVXITEMS_FRMDIR_HORI_RIGHT_TOP,
         RID_SVXITEMS_FRMDIR_VERT_TOP_RIGHT,
         RID_SVXITEMS_FRMDIR_VERT_TOP_LEFT,
-        RID_SVXITEMS_FRMDIR_ENVIRONMENT
+        RID_SVXITEMS_FRMDIR_ENVIRONMENT,
+        RID_SVXITEMS_FRMDIR_VERT_BOT_LEFT
     };
     return RID_SVXITEMS_FRMDIR[nIndex];
 }
diff --git a/include/editeng/editrids.hrc b/include/editeng/editrids.hrc
index 983fb2b05c2d..aa95c68f572e 100644
--- a/include/editeng/editrids.hrc
+++ b/include/editeng/editrids.hrc
@@ -271,6 +271,7 @@
 #define RID_SVXITEMS_FRMDIR_VERT_TOP_RIGHT     
NC_("RID_SVXITEMS_FRMDIR_VERT_TOP_RIGHT", "Text direction right-to-left
(vertical)")
 #define RID_SVXITEMS_FRMDIR_VERT_TOP_LEFT      
NC_("RID_SVXITEMS_FRMDIR_VERT_TOP_LEFT", "Text direction left-to-right
(vertical)")
 #define RID_SVXITEMS_FRMDIR_ENVIRONMENT        
NC_("RID_SVXITEMS_FRMDIR_ENVIRONMENT", "Use superordinate object text direction
setting")
+#define RID_SVXITEMS_FRMDIR_VERT_BOT_LEFT      
NC_("RID_SVXITEMS_FRMDIR_VERT_BOT_LEFT", "Text direction left-to-right
(vertical from bottom)")
 #define RID_SVXITEMS_PARASNAPTOGRID_ON         
NC_("RID_SVXITEMS_PARASNAPTOGRID_ON", "Paragraph snaps to text grid (if
active)")
 #define RID_SVXITEMS_PARASNAPTOGRID_OFF        
NC_("RID_SVXITEMS_PARASNAPTOGRID_OFF", "Paragraph does not snap to text grid")
 #define RID_SVXITEMS_CHARHIDDEN_FALSE          
NC_("RID_SVXITEMS_CHARHIDDEN_FALSE", "Not hidden")


I tested it locally, I don't have the crash with it and the dialog appears.

I'll be able to submit it on gerrit only tonight. If someone wants to do it
before, don't hesitate! :-)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20190925/ed3f3deb/attachment-0001.html>