[Libreoffice-bugs] [Bug 131758] Consistent polygon tool behavior in Draw.

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=131758

--- Comment #5 from Armin Le Grand <Armin.Le.Grand at me.com> ---
Hi Jan,

- What is the correct handling here from your POV?
AFAIK as it was before changes were made in that area. Obviously that touched
stuff which was not on the radar - what always can happen, esp. in areas like
these. Turn back, check was was intended to be changed - there may be good
reasons - and do it in a way without side effects with knowing more
usages/cases

- Would it make sense to split polygon and polyline for more consistent
behavior?

No. The one is filled, the other is not. Only consequent thing needed is to
know the target type (currently in OBJ_TYPE AFAIK, argh, already had that
better in aw080) and adapt each finished polygon in polyPolygon topology

- Is a PolyPolygon just a group of independent polygons, or do they have to
share a common point, as 5.4 handling seems to somehow imply, as it continues
the line?

Yes. No. :-)
Why should they share a point? This makes no sense at all - a polyPolygon is a
bunch of single polygons. Topology defines adapting a FillRule to these when
visualizing. We just have EvenOdd/NonZero where we use EvenOdd only - so it's
more or less a xor - for each point # of being inside %1

Windows PolyPolygon function has: "The PolyPolygon function draws a series of
closed polygons. [...] The polygons drawn by this function can overlap.", which
doesn't exactly answer my last question either. But it suggests it makes sense
split the polyline functionality, so you either draw polygons or polylines.

So from my POV and as I already stated, I think 7.0 is correct, so no fixes are
needed. I'm still for the polygon / polyline split for UX consistency.

What difference do you see between creating polygons or polylines? Only diff is
that one gets outline painted, other get fill painted. Anyways, for our
attributation you can choose both as you wish. It is better  when the filled
polygon is closed, but I would have to check if this is currently a criteria to
offer fill in the attributes - there is also that polygon object type (OBJ_*)

Just tried - it definitely is an error that for polylines it gets closed when
ending the interaction. Try to paint a 'u' shape with the interactive curve
tool - you cannot due to it getting closed - why is that? You need to go to
edit points and correct it to get your 'u' shape. For creating closed polygons
there are the filled variations - if you want a closed but not filled poly,
construct a filled, closed and change fill to non-filled - that's easier that
finding the point tool and work on that poly.

That CTRL+ALT (was it just CTRL before?) behaviour is clearly buggy - when not
using it the line variations (non-filled) are not closed - that's what it
shopuld be.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20200402/1cfa8475/attachment-0001.htm>