[Libreoffice-bugs] [Bug 122894] FILEOPEN DOC: Crash: SwFrame::RemoveFromLayout()

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=122894

--- Comment #12 from Jan-Marek Glogowski <glogow at fbihome.de> ---
(In reply to Xisco Faulí from comment #7)
> The crash got fixed by
> https://cgit.freedesktop.org/libreoffice/core/commit/
> ?id=1052acae9a599c54e518c8fc17d6a994d8778757, however, it still hangs at
> import time...

So I had a look at this. If I revert the whole five patches it crashes:

Initial positioning text wrap:
 * commit dc3e213dcd81be3eee8d139ea5ad55606a44eeff
 * commit f497d1dc27b4fee3db1e2228647a00971922eb5f
 * commit 1052acae9a599c54e518c8fc17d6a994d8778757

Footnote refactoring:
 * commit 642cdf2d8341f0b202f01718ccb63ac1b976e18e
 * commit 24caeee8236576abd92086974c1dbbf15b81a4c5

If I keep that revert and just apply the two broken patches:

 * commit 1052acae9a599c54e518c8fc17d6a994d8778757
 * commit 24caeee8236576abd92086974c1dbbf15b81a4c5

it hangs, but that's the same hang as bug 131530, which I fixed with

 * commit 642cdf2d8341f0b202f01718ccb63ac1b976e18e

which was a Copy'n'Paste bug in my refactoring commit to begin with.

So while comment 7 is correct from the "user perspective", it's simply not true
that the crash was ever "fixed" from the code perspective.

And the valgrind log is the same with or without the whole patchset. See the
attachment 159556.

Just an info for someone trying to fix this, as I just have a symbol build and
the optimization makes this hard to debug further.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20200414/f5dbefe8/attachment.htm>