[Libreoffice-bugs] [Bug 130863] AUTO-REDACT: Disable 'Case Sensitive' checkbox + 'Whole word' checkbox when the 'Regular expression' option is selected

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=130863

--- Comment #26 from Eike Rathke <erack at redhat.com> ---
@Julien: if the checkbox is disabled the test can't set it to case sensitive so
the test fails.

However, IMHO disabling the checkbox in the general F&R dialog is unfortunate,
if not wrong. Not many know the regex (?-i) flag (or other flags for that
matter) and matching case sensitive regex is unnecessarily complicated this
way.

Someone knowing and using the flag can easily figure out what the meaning of
the checkbox is and that the default is case insensitive (checkbox unchecked).
If flags are set in the regex itself then the flags override the global setting
anyway.

Furthermore, for the same reason I consider the already applied changes
(disabling checkbox in redact dialog and keeping the default case sensitive) to
be wrong. The logic should be the same as in the F&R dialog, default case
insensitive and the global flag actually be set accordingly.

I suggest to not do that follow-up change and correct the previous changes.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20200805/1513f8a2/attachment.htm>