[Libreoffice-bugs] [Bug 135238] Reject all removes image not included in track changes since 6.3

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=135238

--- Comment #5 from Telesto <telesto at surfxs.nl> ---
It's reproducible on master

Other than that, you can easily create a reproducer document (new Writer doc,
enable track changes, insert an image, make sure it's anchored as at-char,
reject the change) that will have the same problem, even before the above
commit.

-> This is obvious I think; but not the point

The idea here is that 'tracking changes record being disabled' when adding the
image. However with an 'old' history of changes present. So you add something
to a paragraph which is marked as a change.. Disable record. Add a shape.. And
reject changes.. To paragraph gets deleted including the image (which
technically isn't record as change' and probably shouldn't be deleted. OTOH,
this might be an exception on the rule; and not a big fan of exceptions as
those produce really really specific quirky behavior when broken; being
tremendously hard to trace back. But that's the other side of this case.  

This obviously bit of problematic case; I simply wanted to test what would
happen :-). And did work differently in the past for whatever reason.

The bibisect result is slightly surprising; doesn't make much sense. Would have
expected/ predicted a M. Stahl commit

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20200819/9b29f840/attachment.htm>