[Libreoffice-bugs] [Bug 135164] FILESAVE DOCX: Heading get bullets

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=135164

--- Comment #17 from Julien Nabet <serval2412 at yahoo.fr> ---
On pc Debian x86-64 with master sources updated today with gtk3 or gen
rendering, I don't reproduce the pb with minimized source file.

I also put a trace at the location indicated by:
https://cgit.freedesktop.org/libreoffice/core/commit/?id=04ca5efc800c6b7a6e98e4278eb8be6ac6737fe9

author  Julien Nabet <serval2412 at yahoo.fr>      2020-06-27 09:27:50 +0200
committer       Caolán McNamara <caolanm at redhat.com>    2020-06-27 16:27:13
+0200

cid#1464974: Null pointer dereferences (sw/unosett)

It seems LO doesn't go there.
Also the patch doesn't change functionality, just avoids some null pointer.
diff --git a/sw/source/core/unocore/unosett.cxx
b/sw/source/core/unocore/unosett.cxx
index 817938749bf7..81f1a6a2e33a 100644
--- a/sw/source/core/unocore/unosett.cxx
+++ b/sw/source/core/unocore/unosett.cxx
@@ -1771,8 +1771,8 @@ void SwXNumberingRules::SetPropertiesToNumFormat(
         {
             OUString sBulletFontName;
             rProp.Value >>= sBulletFontName;
-            SwDocShell* pLclDocShell = pDoc->GetDocShell();
-            if( !sBulletFontName.isEmpty() && pLclDocShell )
+            SwDocShell* pLclDocShell = nullptr;
+            if( !sBulletFontName.isEmpty() && pDoc && (pLclDocShell =
pDoc->GetDocShell()) )


Did I miss something?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20201203/d26db62d/attachment.htm>