[Libreoffice-bugs] [Bug 127401] Release Notes button leads to English RN on Chinese system

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=127401

--- Comment #25 from Ming Hua <ming.v.hua at qq.com> ---
After a bit more searching and looking at the previous patches for this bug, I
think I found something.

In sfx2/source/appl/appserv.cxx, which commit
787647b488d02be2acbbad4fa7873508dcb926c2 in comment 10 changed, and fixed this
bug the first time, contains (line 558):

    "&LOlocale=" + LanguageTag(utl::ConfigManager::getUILocale()).getBcp47()

while in cui/source/dialogs/about.cxx there is (line 99 and 100):

    "&LOlocale=" + LanguageTag(utl::ConfigManager::getUILocale()).getLanguage()

Note the difference between getBcp47() and getLanguage().

Which one is used by infobar and which one is used by the About dialog link
now?  My guess is that the latter in about.cxx is used by the About dialog and
wrong, it should also use getBcp47() instead, unless this would negatively
affect other locales.

BTW, I'm by no means a competent programmer, but it seems constructing this URL
for release notes in two different places in code is not a very good idea...

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20201213/ff1f62a3/attachment.htm>