[Libreoffice-bugs] [Bug 138964] New: Metric spinbutton doesn't react to change after key presses

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=138964

            Bug ID: 138964
           Summary: Metric spinbutton doesn't react to change after key
                    presses
           Product: LibreOffice
           Version: 7.0.0.3 release
          Hardware: All
                OS: All
            Status: UNCONFIRMED
          Keywords: bibisected, bisected, implementationError
          Severity: normal
          Priority: medium
         Component: framework
          Assignee: libreoffice-bugs at lists.freedesktop.org
          Reporter: baron at caesar.elte.hu
                CC: caolanm at redhat.com

The following is one example, but I think it's a generic behavior with similar
welded spinbuttons.

- Insert a table in Writer.
- In the Table sidebar panel, erase a signifcant digit in 'Column width' field.

=> Nothing happens.

Before 7.0, the input was validated, and the table immediately got updated with
the adjusted size, now this only happens when the focus leaves the spin field,
the input handler isn't called during editing.

To be honest, I'm not sure if the new behavior is actually worse, because the
automatic update of the field during editing could be annoying (eg. erase the
"." in a < 7.0 version), but it seems more like an unintended side-effect: the
input-handler of the control should be triggered, just the actual spinfield
instances shouldn't specify one. But this is more like a generic UX principle
to consider.

This particular change was introduced in the following commit, bibisected using
repo bibisect-linux-64-7.0, but as I mentioned, the seems more like an
implementation error in the spin field used. Either way, adding CC: to Caolán
McNamara.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=76be71b2afa00ab66a543771c2c1a0894fa3a1ae
author          Caolán McNamara <caolanm at redhat.com>    2019-12-21 14:50:10
+0000
committer       Caolán McNamara <caolanm at redhat.com>    2019-12-30 13:16:54
+0100

weld TableEditPanel

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20201216/d335de01/attachment.htm>