[Libreoffice-bugs] [Bug 130707] FILEOPEN: Writer document "Read Error. Format error discovered in the file in sub-document content.xml at 2, 68950(row, col)."

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=130707

Oliver Brinzing <oliver.brinzing at gmx.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.documentfounda
                   |                            |tion.org/show_bug.cgi?id=10
                   |                            |7776
     Ever confirmed|0                           |1
           Keywords|                            |bibisected, bisected,
                   |                            |regression
                 CC|                            |oliver.brinzing at gmx.de,
                   |                            |vmiklos at collabora.com
             Status|UNCONFIRMED                 |NEW

--- Comment #2 from Oliver Brinzing <oliver.brinzing at gmx.de> ---
reproducible:

attached document will open with:

Version: 6.2.8.2 (x64)
Build-ID: f82ddfca21ebc1e222a662a32b25c0c9d20169ee
CPU-Threads: 4; BS: Windows 10.0; UI-Render: Standard; VCL: win; 
Gebietsschema: de-DE (de_DE); UI-Sprache: de-DE
Calc: 

but fails to open with:

Version: 6.3.5.1 (x64)
Build-ID: 9a62adaf9abe90e8fef419f29114b0176dd66801
CPU-Threads: 4; BS: Windows 10.0; UI-Render: Standard; VCL: win; 
Gebietsschema: de-DE (de_DE); UI-Sprache: de-DE
Calc: 

seems to have started with:

https://gerrit.libreoffice.org/plugins/gitiles/core/+/28d67b792724a23015dec32fb0278b729f676736

tdf#107776 sw ODF shape import: make is-textbox check more strict

Regression from commit 9835a5823e0f559aabbc0e15ea126c82229c4bc7 (sw
textboxes: reimplement ODF import/export, 2014-10-04), the problem was
that we assumed graphic autostyles look like:
    <style:style style:name="gr2" style:family="graphic">

for simple (non-text-box) content, and look like:
    <style:style style:name="gr1" style:family="graphic"
style:parent-style-name="Frame">

for complex (text-box) content.

Turns out it's valid to have other parent styles as well, e.g. Graphics,
which should not be imported as sw textboxes.

With this, the arrow at the bottom of page 3 of the bugdoc is now again
on top of the image, i.e. layout compatibility is restored.

Change-Id: Icbba8a23c5f66e63090f90e6581ebc98948cb80b
Reviewed-on: https://gerrit.libreoffice.org/78155
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos at collabora.com>

/cygdrive/d/sources/bibisect/bibisect-win64-6.4
$ git bisect bad
b5fe45c9bd4aed26448fddff2064f43595d5abd6 is the first bad commit
commit b5fe45c9bd4aed26448fddff2064f43595d5abd6
Author: Norbert Thiebaud <nthiebaud at gmail.com>
Date:   Wed Sep 4 04:44:34 2019 -0700

    source sha:28d67b792724a23015dec32fb0278b729f676736
    source sha:28d67b792724a23015dec32fb0278b729f676736

:040000 040000 3ced65b7409548e586e456539a31221c3090ddfe
255015855cc0f4a46053a0ef5caabd28d599c2ef M      instdir

/cygdrive/d/sources/bibisect/bibisect-win64-6.4
$ git bisect log
# bad: [75af2782b7f006d1c31ad11e84d5ab6bd7f74ed0] source
sha:20be5cd0bdc57d812bf34a2debfe48caa51de881
# good: [8d1eaf05d47fd1c56ddecbe57a9a7c8289ede7f4] source
sha:c98b1f1cd43b3e109bcaf6324ef2d1f449b34099
git bisect start 'master' 'oldest'
# good: [e13037966b62b9d258d5cf6d96586de5e2bafea8] source
sha:4a0b2b8024fa6fb8a0ab3e474b7d64fc455028b5
git bisect good e13037966b62b9d258d5cf6d96586de5e2bafea8
# bad: [7cba838374e1acd7b8a6e114d7b12bf6370cd7ab] source
sha:d6ea967e040d01ec69649ac689472018e477db34
git bisect bad 7cba838374e1acd7b8a6e114d7b12bf6370cd7ab
# bad: [f57765d2816781c79fc36e1d4955bff1c5c92f8d] source
sha:130b0ffd491015df2dc1d6b272952d76980f0465
git bisect bad f57765d2816781c79fc36e1d4955bff1c5c92f8d
# bad: [a5806767f5af962cc752a93c633c2a8eb53b7ada] source
sha:17f9aa97f8753b895db30e8080481f5f6d696b82
git bisect bad a5806767f5af962cc752a93c633c2a8eb53b7ada
# bad: [dbd346c63ce5bf99a9d1c46c7e29c78972977a36] source
sha:9c06059ec546683bfa095cf4f59ac6ea94da34fb
git bisect bad dbd346c63ce5bf99a9d1c46c7e29c78972977a36
# bad: [caf6f8b4af35f8f14343e5041a3c9d48b35c786b] source
sha:f38566826cdd257214298c583a1ce8ae6715713c
git bisect bad caf6f8b4af35f8f14343e5041a3c9d48b35c786b
# bad: [48d97fced7916f15dd322390f321618e868d92fd] source
sha:0466c3d8b2589a2982b919145cdacc9a1eeb63ff
git bisect bad 48d97fced7916f15dd322390f321618e868d92fd
# good: [6037b377b38871b6c0d4b1c19b916d39a04ae140] source
sha:b5317b2a41e6369e2804462e2ab73f1447f1533a
git bisect good 6037b377b38871b6c0d4b1c19b916d39a04ae140
# good: [026b06d4f3ec456b403e7d15838ad97dd57fe453] source
sha:09d29fab72e22ba830f178b15a74a5a87c8a73a5
git bisect good 026b06d4f3ec456b403e7d15838ad97dd57fe453
# bad: [437a426a5079edae06923c2eba69aadaab8db089] source
sha:9c470a376a8cf5d42d2adbe2e528f3fe6b2df7ee
git bisect bad 437a426a5079edae06923c2eba69aadaab8db089
# good: [8fa3dea6409f0eaf294f9b20374a95906406dd8c] source
sha:5c50f1a2d4487b9303974c7cf39d6208192a0c96
git bisect good 8fa3dea6409f0eaf294f9b20374a95906406dd8c
# bad: [ccb3e1875f334d4970d9ed9ecad7a3e8fda68c6c] source
sha:a1f2f8bdff465ada957f394530cd791a0c329da4
git bisect bad ccb3e1875f334d4970d9ed9ecad7a3e8fda68c6c
# bad: [b5fe45c9bd4aed26448fddff2064f43595d5abd6] source
sha:28d67b792724a23015dec32fb0278b729f676736
git bisect bad b5fe45c9bd4aed26448fddff2064f43595d5abd6
# first bad commit: [b5fe45c9bd4aed26448fddff2064f43595d5abd6] source
sha:28d67b792724a23015dec32fb0278b729f676736

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20200216/51a3285e/attachment.htm>