[Libreoffice-bugs] [Bug 130981] New: Simplify uses of sal_math_Double

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=130981

            Bug ID: 130981
           Summary: Simplify uses of sal_math_Double
           Product: LibreOffice
           Version: unspecified
          Hardware: All
                OS: All
            Status: UNCONFIRMED
          Keywords: difficultyBeginner, easyHack, skillCpp, topicCleanup
          Severity: enhancement
          Priority: medium
         Component: LibreOffice
          Assignee: libreoffice-bugs at lists.freedesktop.org
          Reporter: mikekaganski at hotmail.com
                CC: sbergman at redhat.com

We have a helper union sal_math_Double (defined in include/sal/mathconf.h) to
help low-level access to double parts. It already has a member "value" of type
double, representing the resulting value.

Throughout the code, the union is sometimes used inside other unions along with
a double member, duplicating the already present "value". See e.g.
sc/source/filter/oox/biffhelper.cxx and include/rtl/math.hxx. These usages may
be simplified to avoid these extra unions (and e.g. drop DecodedDouble
completely from sc/source/filter/oox/biffhelper.cxx).

So the task is to look through all the uses of the union, and simplify those
unnecessary complications.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20200227/6905ee43/attachment-0001.htm>