[Libreoffice-bugs] [Bug 131000] New: Form control property editor for combo box opens very slow for large entry list

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=131000

            Bug ID: 131000
           Summary: Form control property editor for combo box opens very
                    slow for large entry list
           Product: LibreOffice
           Version: 6.1.6.3 release
          Hardware: All
                OS: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: medium
         Component: UI
          Assignee: libreoffice-bugs at lists.freedesktop.org
          Reporter: glogow at fbihome.de

Description:
When opening the property editor dialog to edit the combo box in the attached
bug document with 4000 entries, LO is stuck busy for a long time, without UI
refresh and no possibility for the user to interact with the program. You
literally have to wait minutes until LibreOffice becomes responsive again here.

There is no problem using the combo box itself, just the property editor in
design mode.

This happens, because the combo box entries are kept in a small MultiLineEdit
text field. LO is busy formating that text, which doesn't fit at all in the
line. A debugger shows it's stuck the whole time in TextEngine::CreateLines.
This was unintentionally already fixed in master by commit 1efeb17837c2 ("weld
Property Browser"), which completely changed this line editor (and other parts
of the dialog) into a single line Edit field and a TextView in a popup menu.
But the patch itself "weld"es the whole dialog (68 files changed, 2124
insertions, 2871 deletions) and is much too large for a backported fix.

But the real solution is simple: just replace the MultiLineEdit with an Edit.
The real editing is done in the dropdown anyway, so no functionally is really
lost. The one difference is the fact, that now you never can edit the text
directly, but just in the popup. That cuts down the time from minutes to a few
seconds here.

The handling could probably be optimized further, as the content is based on
Calc cells, so you can't even edit the entries in the case, but for a
"backport", the result is sufficient.

Steps to Reproduce:
1. Open bug document
2. Switch to design mode
3. Open the combo box "Control..." properties

Actual Results:
LO is busy looping without UI refresh.

Expected Results:
LO is interactive.


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 6.1.6.3
Build ID: 5896ab1714085361c45cf540f76f60673dd96a72
CPU threads: 8; OS: Linux 4.19; UI render: default; VCL: kde4; 
Locale: de-DE (de_DE.UTF-8); Calc: group threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20200228/72ef9eef/attachment-0001.htm>