[Libreoffice-bugs] [Bug 130137] New: Replace remaining uses of WNT define checks with _WIN32

bugzilla-daemon at bugs.documentfoundation.org bugzilla-daemon at bugs.documentfoundation.org
Thu Jan 23 10:24:14 UTC 2020


https://bugs.documentfoundation.org/show_bug.cgi?id=130137

            Bug ID: 130137
           Summary: Replace remaining uses of WNT define checks with
                    _WIN32
           Product: LibreOffice
           Version: unspecified
          Hardware: All
                OS: All
            Status: UNCONFIRMED
          Keywords: difficultyBeginner, easyHack, skillCpp, topicCleanup
          Severity: normal
          Priority: medium
         Component: LibreOffice
          Assignee: libreoffice-bugs at lists.freedesktop.org
          Reporter: mikekaganski at hotmail.com

https://opengrok.libreoffice.org/search?project=core&full=WNT&type=cxx&n=50

Here are available some instances of precompiler checks like

> #elif defined WNT

We already had some cleanups replacing checks for windows to uniform _WIN32 -
see

https://git.libreoffice.org/core/+/ce43d0ae9279edbf1ad108fe0d8325327a038d49
https://git.libreoffice.org/core/+/92ed91610d30246e671226da081da748f6b16aae
https://git.libreoffice.org/core/+/fda27303cfb84ef182696787878dba06c4a129da
https://git.libreoffice.org/core/+/e1e39fac2203d10f8a19b18558c42a1943ad8736
etc.

But these in the opengrok list are likely leftovers from those commits. The
easy hack is to clean up them to use consistent check for _WIN32.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20200123/11085fed/attachment-0001.htm>


More information about the Libreoffice-bugs mailing list