[Libreoffice-bugs] [Bug 133775] UI: Copy about text translated too

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=133775

--- Comment #9 from Mike Kaganski <mikekaganski at hotmail.com> ---
(In reply to Heiko Tietze from comment #6)
> In cui/source/dialog/about.cxx function IMPL_LINK_NOARG(AboutDialog,
> HandleClick, weld::Button &, void) the two strings m_pEnvLabel and
> m_pUILabel are taken from the actual label. These labels are assigned via
> vcl/source/app/svapp.cxx Application::GetHWOSConfInfo() using VclResId() for
> l10n. No idea how to retranslate. And the function is also used in
> updatefeed.cxx so we cannot just cut l10n.
> 
> => not worth the effort

Please make it clean and pretty.

To translate that in Application::GetHWOSConfInfo, just add the second variant
of VclResId to vcl/source/app/svdata.cxx (and resp. header):


> OUString VclResId(const char* pId, const OUString& rsBcp47LanguageTag)
> {
>     return Translate::get(pId, Translate::Create("vcl", LanguageTag(rsBcp47LanguageTag)));
> }

... and add respective argument to Application::GetHWOSConfInfo. Depending if
you put there an empty string or "en-US", it would you either the default
VclResId, or the new one.

The "not worth the effort" and WONTFIX are wrong, that's not pretty with a
doable fix.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20200707/c5cd80f6/attachment.htm>