[Libreoffice-bugs] [Bug 125905] [META] DOC: Regressions introduced by 705a8c226aee3e68db492083b7cf8b704335328b

bugzilla-daemon at bugs.documentfoundation.org bugzilla-daemon at bugs.documentfoundation.org
Thu Jul 16 08:22:24 UTC 2020


https://bugs.documentfoundation.org/show_bug.cgi?id=125905

--- Comment #2 from Justin L <jluth at mail.com> ---
In order to easily test for this regression with linux bibisect-44max:

first bad bibisect commit bdd0a608f23b1c4e54e3ec396e888cd40e2afa6f

    source commit 705a8c226aee3e68db492083b7cf8b704335328b
    Author:     Caolán McNamara on Wed Sep 24 10:04:48 2014 +0100

WW8PLCFMan::AdjustEnds deeply flawed concept wrt change tracking

The whole idea of clipping the char attributes to before the cr that word uses
as the end of para marker is flawed from especially the perspective of
redlining which is a char property in word.

If the redline encompasses the newline in order to state that it is deleted,
then if the prop is clipped to before that newline then the end-of-para doesn't
get marked as deleted

For now just remove the character attributes clipping from here to be as
conservative as possible.

Hopefully the ordering of processing start pap before start chp and end chp
before end pap and the other million improvements in the parser that came about
after AdjustEnds was created avoids whatever problems were trying to be worked
around here.
Change-Id: I5a72e462db2fff60f52b12c2125ea6ac363de695

===============================

first good bibisect commit 30f5a584d5dcd60adfbfd897305f47cd8f71961c
    source commit 6332c643016ce4c4d254c8429a5eceae6664bf5c
    Author:     Samuel Mehrbrodt on Wed Sep 24 10:38:26 2014 +0200

    fdo#83955 Fix changes toolbar to display icons+text

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20200716/b2c06fa6/attachment-0001.htm>


More information about the Libreoffice-bugs mailing list