[Libreoffice-bugs] [Bug 135121] UI: Font color toolbar icon looks off after setting it to automatic

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=135121

Maxim Monastirsky <momonasmon at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
                 CC|                            |caolanm at redhat.com,
                   |                            |momonasmon at gmail.com,
                   |                            |riz_17_oke at yahoo.co.id
           See Also|                            |https://bugs.documentfounda
                   |                            |tion.org/show_bug.cgi?id=13
                   |                            |4084,
                   |                            |https://bugs.documentfounda
                   |                            |tion.org/show_bug.cgi?id=13
                   |                            |4928
             Status|UNCONFIRMED                 |NEW

--- Comment #5 from Maxim Monastirsky <momonasmon at gmail.com> ---
Basically I see 2 problems here:

1) The color button is bigger than the other buttons on the toolbar, causing
the color stripe to not align well with the stripe from the base icon (red or
rainbow, depending on the icon theme), so some pixels of the icon's stripe are
always visible. This seems to be a result of:

commit 3c17bb91f29d431f99a742bd14ffc9612f25a7af
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Fri Jun 19 15:06:23 2020 +0100

    tdf#134084 use the desired image size, not the current image size

    when updating the color bar

    Change-Id: I6bf76a38adc034a25c0c31833c14f2b6afe3ec6d

This commit hardcoded height of 26 for large size, but some icon themes
actually have height of 24.

2) The stripe for automatic color is transparent (with just a black border),
revealing what's in the base icon underneath it. That's a red or rainbow,
depending on the icon theme. Possible solutions are: (a) Not have any stripe in
the base icon, see Bug 134928 comment 9. (b) Use an actual fill color instead
of transparent to indicate the automatic color. This actually used to be the
case in the past (at least in LO 5.3). This isn't a recent regression, but
still might be useful to bibisect.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20200726/e6988651/attachment.htm>